Update User-Agent strings for Firefox/Opera/Chrome/Edge - #793
Open
mtskg wants to merge 1 commit into
Open
Conversation
mtskg
commented
Nov 12, 2023
- Following the same pattern as in 75c67a6 which also included developer and beta updates of Opera.
houseme
approved these changes
Jan 15, 2024
Member
|
Could you please update the PR to the latest versions and keep only the version strings that are supported by their devs? |
|
StantonMatt
suggested changes
Jun 3, 2026
StantonMatt
left a comment
There was a problem hiding this comment.
I checked the current head 25dfb510 against current master.
Local checks:
go test ./extensions -count=1
go test ./... -count=1
git diff --check origin/master...HEAD
Those pass. gofmt -l extensions/random_user_agent.go still reports extensions/random_user_agent.go.
I think the update still needs another pass before it matches the maintainer request to use latest supported version strings:
- The added lists stop at Firefox/Chrome 119. Current official feeds I checked report Firefox
151.0.3/ DevEdition152.0b6fromhttps://product-details.mozilla.org/1.0/firefox_versions.json, and Chrome stable Windows149.0.7827.54from ChromiumDash. - One added Chrome entry is release-note shorthand rather than a UA-safe version:
114.0.5735.90/91. SincegenChromeUAemits it asChrome/%s, that can produceChrome/114.0.5735.90/91 Safari/.... A local-only guard test overchromeVersionsfailed on that exact value.
So I would refresh the data against current supported versions, split/remove shorthand entries, and add a small guard test for UA-safe Chrome version strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.